Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input/textarea focus border color in dark theme #507

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Nov 11, 2024

Description

  • forces border color to be blue on focus
    • i'd argue this is an ok usage of !important, I don't want to find every place where the border-color is redefined and redefine the focus color, and that's not something we want to have to remember to do in the future either
  • additionally, fixed checkbox border color to match with inputs (as seen in the last row of images)

Screenshots

before after
image image
image image
image image
image image
image image

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #

@js0mmer js0mmer temporarily deployed to staging-507 November 11, 2024 23:50 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-507 November 13, 2024 22:45 — with GitHub Actions Inactive
@js0mmer js0mmer merged commit deb8b14 into main Nov 13, 2024
2 checks passed
@js0mmer js0mmer deleted the fix-input-outline-dark-theme branch November 13, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants